Device flow: single state resolver + shared terminal-state partial

The terminal states (expired / already-used / not-found) were duplicated as
markup in show and result, and #verify re-implemented the nil→expired→!pending
cascade that #show already had — a copy edit meant four touch points.

- device_code_state(dc) resolves a code to :not_found / :expired /
  :already_handled / :ok. Both #show and #verify branch on it, so the cascade
  lives in one place.
- _terminal_state partial renders the terminal heading/message/link once;
  result.html.erb now renders it instead of inlining the markup.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01F7cwhwDJp3MJJDoNPVE6zq
This commit is contained in:
Dan Milne
2026-07-19 14:10:04 +10:00
co-authored by Claude Opus 4.8
parent e3f0bd4cab
commit 79a7524fda
4 changed files with 73 additions and 30 deletions
@@ -280,6 +280,39 @@ class OidcDeviceFlowControllerTest < ActionDispatch::IntegrationTest
assert_redirected_to signin_path
end
# --- Terminal-state rendering (shared resolver + partial) ------------------
test "show prompts for a code when none is given" do
sign_in_as(@user)
get "/device"
assert_response :success
assert_match(/Enter device code/i, @response.body)
end
test "show renders the not-found terminal state for an unknown code" do
sign_in_as(@user)
get "/device", params: {user_code: "ZZZZ9999"}
assert_response :success
assert_match(/Code not found/i, @response.body)
end
test "show renders the expired terminal state" do
sign_in_as(@user)
dc = OidcDeviceCode.create!(application: @cli, scope: "openid", expires_at: 1.minute.ago)
get "/device", params: {user_code: dc.user_code}
assert_response :success
assert_match(/Code expired/i, @response.body)
end
test "verify renders the terminal state for an already-handled code" do
sign_in_as(@user)
dc = OidcDeviceCode.create!(application: @cli, scope: "openid")
dc.deny!
post "/device", params: {user_code: dc.user_code}
assert_response :success
assert_match(/Code already used/i, @response.body)
end
# Introspection is covered in depth in oidc_introspection_test.rb.
private