Fix 500 when deleting an application with device codes
Deleting an application left its oidc_device_codes orphaned, tripping the FK constraint and raising SQLite3::ConstraintException. Unlike the other child tables, oidc_device_codes had neither a dependent: :destroy association nor an on_delete: :cascade FK, so any app that had started a device-authorization flow could not be deleted (regardless of groups/users, since a pending device code has a null user_id). Add the missing has_many :oidc_device_codes, dependent: :destroy and a migration to cascade at the DB level, mirroring application_user_claims. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LARKs4cVsGrvKCkKZhPcy6
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
51ddb42bc7
commit
45a1203647
@@ -0,0 +1,14 @@
|
||||
class AddCascadeToOidcDeviceCodesApplicationFk < ActiveRecord::Migration[8.1]
|
||||
# Deleting an application left its oidc_device_codes orphaned, tripping this
|
||||
# FK and 500ing the destroy. Mirror application_user_claims: cascade at the DB
|
||||
# level so the delete is safe even if the model-layer cascade is bypassed.
|
||||
def up
|
||||
remove_foreign_key :oidc_device_codes, :applications
|
||||
add_foreign_key :oidc_device_codes, :applications, on_delete: :cascade
|
||||
end
|
||||
|
||||
def down
|
||||
remove_foreign_key :oidc_device_codes, :applications
|
||||
add_foreign_key :oidc_device_codes, :applications
|
||||
end
|
||||
end
|
||||
Reference in New Issue
Block a user